-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantize elementwise mul #40546
Quantize elementwise mul #40546
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one typo. The rest looks good to me.
PATTERN_DECL_NODE(elementwise_add_out); | ||
// Elementwise ops | ||
// Forward pass for element-wise operators (add, mul) | ||
// elementwise_mul_out is the result of the operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of elementwise_mul_out
should be elementwise_out
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify this comment in your next PR. @zuzg Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Quantize elementwise mul op * Parametrize elementwise functions * Fix code formatting
PR types
New features
PR changes
OPs
Describe
Quantization of elementwise multiplication operator and generalizing functions connected with quantized elementwise operators.